AP_HAL_ChibiOS: Set RADIX2HD HAL_I2C_INTERNAL_MASK #25672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyp1per
approved these changes
Dec 1, 2023
|
@andyp1per thanks for the confirmation! |
|
This is included in Copter-4.4.4-beta1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The detection of external compasses wasn't working and I though I had it fixed in #25291. It still wasn't working because
HAL_I2C_INTERNAL_MASKwasn't set and so no external buses were scanned (asHAL_I2C_INTERNAL_MASKdefaults to 1).Note that for some reason it was working with the HMC5983 I used for testing, but other compasses, e.g., the QMC5883L were not working.